unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
368 stars 24 forks source link

No-Intro NES dat generating an error message #263

Closed specialt1212 closed 1 year ago

specialt1212 commented 1 year ago

Describe the bug Retool 2.00.4

| DAT DETAILS | Description: Nintendo - Nintendo Entertainment System (Headered) (Private) | Author/s: aci68, Arctic Circle System, baldjared, BigFred, bikerspade, BitLooter, Blank, C. V. Reynolds, chillerecke, DeadSkullzJr, DeriLoko3, EggmanPEI, einstein95, fuzzball, Gefflon, Hiccup, jimmsu, Just001Kim, kazumi213, Lesserkuma, Madeline, Money_114, NESBrew12, niemand, nnssxx, norkmetnoil577, NovaAurora, omonim2007, Powerpuff, PPLToast, rarenight, relax, RetroUprising, Rifu, sCZther, SonGoku, Special T, Tauwasser, ToeKnee, togemet2, UnlockerPT, Vigi, xuom2 | URL: https://www.no-intro.org | Version: 20230520-071425 | Numbered dat: No

Retool has had an unexpected error. Please raise an issue at https://github.com/unexpectedpanda/retool/issues, attaching the DAT file that caused the problem and the following trace:

multiprocessing.pool.RemoteTraceback: """ Traceback (most recent call last): File "multiprocessing\pool.py", line 125, in worker File "multiprocessing\pool.py", line 48, in mapstar File "modules\chooseparent.py", line 1960, in choose_parent_process File "modules\chooseparent.py", line 545, in choose_date File "modules\titletools.py", line 986, in get_date ValueError: invalid literal for int() with base 10: '' """

The above exception was the direct cause of the following exception:

Traceback (most recent call last): File "retoolgui.py", line 175, in run File "retool.py", line 212, in main File "modules\chooseparent.py", line 1649, in choose_parent File "multiprocessing\pool.py", line 367, in map File "multiprocessing\pool.py", line 774, in get ValueError: invalid literal for int() with base 10: ''

The error occurred on this file: G:\Tools & System Backups_Retool (1G1R)_dats_FROM_DOM_Nintendo - Nintendo Entertainment System (Headered) (Private) (20230520-071425).dat

======================================================

To reproduce It happens ever time I try to process this dat

_FROM_DOM_Nintendo - Nintendo Entertainment System (Headered) (Private) (20230520-071425).zip

Expected behavior A new dat should be created but retool generates the error listed above

Operating system

Retool edition

Retool version 2.00.4

Are you using custom global or system filters? If so, list them below Global excludes: Everything on the exclusions tab except bad dumps and unlicensed (see attachment)

*you can ignore the dat loaded in this image it was just the one I had loaded when I took the printscreen. The only dat giving me an error is the one I linked above Preferences - 04

What other settings are you using? everything else default

unexpectedpanda commented 1 year ago

Ah, another of No-Intro's inconsistent date formats causing issues.

It looks like an attempt at RFC 3339 without the time zone. I'll look into it.

unexpectedpanda commented 1 year ago

After doing some digging -- this one is my fault. I didn't process this particular date format properly. Fixed in 2.00.5.