unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
355 stars 23 forks source link

Titles being as both parent and clone #265

Closed 0xC0D3D34D closed 1 year ago

0xC0D3D34D commented 1 year ago

Describe the bug Retool 2 is keeping clones in the output dat as both are being set as parent of each other.

eg Finding Nemo - The Continuing Adventures (Europe) (En,Es,It,Sv,Da) Finding Nemo - The Continuing Adventures (USA, Europe)

All seem to be happening with (Europe) + (USA, Europe) variations. I think there are 19 occurrences in this dat. Is it an issue with handling variants with multiple regions? When traced only the first one shows for Europe, surely both should match for European region.

To reproduce Set Europe as highest priority region, tick all excludes. Run latest No-intro GBA dat

Expected behavior Keep the Europe version of the game that matches language (Eng as no language set), this was the behavior in v1

Operating system

Retool edition

Retool version 2.00.0-2.00.5

Are you using custom global or system filters? If so, list them below

No filters only all exclusions ticked

What other settings are you using?

Europe region moved to the top

unexpectedpanda commented 1 year ago

At the individual region filtering stage, the following happens:

As such, both titles go through to the stage where all the regions are bundled together and compared, but there aren't enough checks there to filter things further down to just one winner, which confuses things.

In the next version, Retool adds two fallbacks: first a check is done based on user language order preference. If that fails, it tries to give priority to the title with the most regions.

unexpectedpanda commented 1 year ago

Fixed in v2.01.0.