search

unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
343 stars 22 forks source link

Update pyproject toml #311

Closed thiagokokada closed 4 months ago

thiagokokada commented 4 months ago

It seems the recent versions of retool migrated from Poetry to Hatch for build system. This broke the packaging (missing script entry points), so I am providing fixes. This should get something like this working again:

$ hatch build # will build wheels
$ hatch shell # start a development environment
$ python3 -m retool # run retool from the development environment

Also I did some formatting in pyproject.toml and updated the docs. If this is unwanted I can revert the changes.

unexpectedpanda commented 4 months ago

Thanks, very much appreciated. I'm relatively new to Python environments, and basically am running everything with global installs (I develop a single project, so can get away with not following the practice -- but have been aware for some time that it's something I should do).

I never really used Poetry for developing Retool, I just included it for those who prefer it. Hatch is just managing a new test suite at this stage, although with time hopefully that expands. I thought I could get away with providing an option for people to use either, but perhaps that's not feasible unless I use a separate hatch.toml or something. Even then perhaps I should just select one environment/package manager.

Entry points are a new concept for me too. Looks like I've got a bit to learn :)

thiagokokada commented 4 months ago

I thought I could get away with providing an option for people to use either, but perhaps that's not feasible unless I use a separate hatch.toml or something.

Yes, this does not really work because you can only have one [build-system]. Since it is set to Hatch, it needs to be Hatch all the way.

Even then perhaps I should just select one environment/package manager.

This does make sense.

Entry points are a new concept for me too.

Yes, they're not really complicated but it is kinda strange if you come from other languages.

Looks like I've got a bit to learn :)

Hey, this project is amazing in any way. Keep the good work.

I have zero issues with whatever you decide to use. I just need it to be consistent since I am trying to package it in NixOS/nixpkgs.

thiagokokada commented 4 months ago

If you do want to keep the hybrid Hatch/Poetry approach I can restore the Poetry configuration. Just keep in mind that not everything will work correctly because of the [build-system] issues I cited earlier.

thiagokokada commented 4 months ago

@unexpectedpanda Can you do a new release? I want to update the package in NixOS/nixpkgs and it would be easier to have a new release to do so.

unexpectedpanda commented 4 months ago

That's a few weeks out at this stage, there are a few things in flight.