unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
354 stars 23 forks source link

Retool v0.95 crashes on No-Intro "Commodore - Plus-4" DAT #99

Closed Freeben666 closed 3 years ago

Freeben666 commented 3 years ago

Describe the bug Retool crashes when processing DAT "Commodore - Plus-4 (20090105-000000).dat" from No-Intro

To reproduce Clean install retool v0.95 and process the DAT

Expected behavior Having a filtered DAT in output

Operating system

Retool edition

Retool version

Are you using custom global or system filters? If so, list them below

Global excludes: None

Global includes: None

System excludes: None

System includes: None

What other settings are you using?

Additional context

* Reading dat file: "D:\Emulation\Tools\Retool\DATs\Commodore - Plus-4
  (20090105-000000).dat"
* Validating dat file... file is a Logiqx dat file.
* Converting dat file to a searchable format... done.
* Checking if the input dat is numbered... this isn't a numbered dat.
* Gathering stats... done.

|  DAT DETAILS
|  Description: Commodore - Plus-4
|  Author: None
|  URL: http://www.no-intro.org
|  Version: 20090105-000000

* Finding titles in regions... done.
* Finding parents across regions... done.
* Checking already excluded titles for includes... done.
Traceback (most recent call last):
  File "retool-gui.py", line 1020, in <module>
  File "retool-gui.py", line 622, in main
  File "retool.py", line 374, in main
  File "modules\output.py", line 196, in write_dat_file
  File "modules\xml.py", line 696, in header
AttributeError: 'NoneType' object has no attribute 'replace'
[12012] Failed to execute script retool-gui
unexpectedpanda commented 3 years ago

Thanks! Fixed in 0.96.