search

unfold / heroku-buildpack-pnpm

Run PNPM install on Heroku
MIT License
38 stars 39 forks source link

Downloading PNPM fails #26

Closed TheSecurityDev closed 1 year ago

TheSecurityDev commented 1 year ago

Running the install command curl -sL https://unpkg.com/@pnpm/self-installer | node fails now with:

[stdin]:1
<!DOCTYPE html>
^

SyntaxError: Unexpected token '<'
    at new Script (node:vm:100:7)
    at createScript (node:vm:257:10)
    at Object.runInThisContext (node:vm:305:10)
    at node:internal/process/execution:81:19
    at [stdin]-wrapper:6:22
    at evalScript (node:internal/process/execution:80:60)
    at node:internal/main/eval_stdin:29:5
    at Socket.<anonymous> (node:internal/process/execution:212:5)
    at Socket.emit (node:events:406:35)
    at endReadableNT (node:internal/streams/readable:1329:12)

I think it's related to the latest commit: https://github.com/unfold/heroku-buildpack-pnpm/commit/76cf1fc471c7a411195057fb0d938cdaa5319af2

Can it be changed to the new URL so we're not using unpkg.com?

TheSecurityDev commented 1 year ago

Actually I discovered this can be fixed by changing the install command to be npm install -g pnpm