search

unfold / heroku-buildpack-pnpm

Run PNPM install on Heroku
MIT License
38 stars 39 forks source link

Fix script not waiting for pnpm installation complete #40

Closed tom-quiltt closed 1 year ago

tom-quiltt commented 1 year ago

Closes: https://github.com/unfold/heroku-buildpack-pnpm/issues/39

Turbo87 commented 1 year ago

I'm not particularly familiar with bash scripting. Can you explain why this now waits for the installation to complete and why it didn't do so before? the code looks equivalent to me on first glance 😅

tom-quiltt commented 1 year ago

To be honest, not a bash script expert here, but the old script seems to wait for the curl and node to complete, so I just rewrite it do be within the same if block and it seems to "wait" for the last install script to complete and able to call pnpm.

Turbo87 commented 1 year ago

I guess this can be closed too, now that #42 was merged :)