search

unfoldadmin / django-unfold

Modern Django admin theme for seamless interface development
https://unfoldadmin.com
MIT License
1.94k stars 188 forks source link

fix: add missing error messages to login template #743

Closed jose-padin closed 2 months ago

jose-padin commented 2 months ago

There were missing error messages when a user tried to perform a log in. In this case, the errors came from the django-password-expire package. Some users were blocked because their passwords had expired, but they couldn´t see the error in the UI. This PR fixes this bug by adding those error messages to the src/unfold/templates/admin/login.html template.

lukasvinclav commented 2 months ago

Why you closed the issue which you created for this PR? Does it mean that you already solved your problem and you just forgot to close this PR as well?

jose-padin commented 2 months ago

Hi, @lukasvinclav. I didn't close the issue, I closed a previous PR because I thought it was not well done. I didn't create an issue for this bug. Do you want me to create one?

lukasvinclav commented 2 months ago

I can confirm there is an issue with displaying errors in login.html.

lukasvinclav commented 2 months ago

Thanks for report. Issue fixed in this PR #772