# In case of tabs, we need to check if the query params are the same
if tabs and query_params != request_params:
return False
shouldn't we compare whether the tabs have query params at all? The current implementation won't highlight for tabs with no query params + manually applied filters
The PR doesn't work when the tabs have different models (without any query params) - it doesn't highlight the tab correctly when filters are applied.
Without filters: screenshot with filters: screenshot
from the code:
shouldn't we compare whether the tabs have query params at all? The current implementation won't highlight for tabs with no query params + manually applied filters