search

unfoldedcircle / feature-and-bug-tracker

Feature and bug tracker repository for Unfolded Circle products
22 stars 0 forks source link

Activity UI not closed when calling the "Activity off" sequence from UI #146

Open KarlKiel opened 9 months ago

KarlKiel commented 9 months ago

Is there an existing issue for this?

Description

Now that it is possible (again) to call the "Activity OFF" command directly from macro or assign it to button there is a non logical behavior happening: If you call the "Activity OFF" command from its' own UI the UI itself will not close - which means that you will stay on the UI of the activity even though the activity is in the state "off" which makes no sense, as you will not be able to control the activity if it is in OFF state at all.

How to Reproduce

  1. Create an activity
  2. Define a meaningful "Off sequence"
  3. In the UI of the activity define a button and configure it to call the "Activity OFF" command.
  4. Start the activity via remote
  5. Press the defined button Outcome: --> The "Activity OFF" sequence will be executed, the activity will go into "off" state - nevertheless the Activity UI will remain open/visible on the remote

Expected behavior

I would expect that if the activity is closed the UI of the activity will also be closed at the same time, as there is no value in keeping it open as it will not be functional if the activity is in "Off" state anyhow.

System version

No response

What part of the system affected by the problem?

No response

Additional context

No response

zehnm commented 8 months ago

Sounds like a good enhancement. @martonborzak can you add this in the UI? The off event for an activity should be sent, otherwise let me know.