search

unfoldedcircle / feature-and-bug-tracker

Feature and bug tracker repository for Unfolded Circle products
22 stars 0 forks source link

[bug] Dock led brightness setting doesn't work #178

Closed GitPetri closed 6 months ago

GitPetri commented 8 months ago

Is there an existing issue for this?

Description

How to Reproduce

  1. Open web configurator
  2. Go to a dock setting
  3. Set led brightness slider to any value. It doesn't matter whether the new value is lower or higher than the default 66 %
  4. Observe 'Change has been saved.' -message on UI
  5. Close dock setting
  6. Open dock setting
  7. Led brightness is back at default value 66 % image image image

Expected behavior

Setting Led brightness value will set led brightness.

System version

Dock 0.9.2

What part of the system affected by the problem?

Web Configurator, Overall system

Additional context

https://github.com/unfoldedcircle/feature-and-bug-tracker/issues/51 might be related to this.

zehnm commented 8 months ago

The 66% is only a display issue: the configured value in the dock isn't read out yet. That will be fixed.

Setting the dock brightness value works however. Certain error notifications are still shown, even with brightness set to 0. This has been a design decision, but we will consider a "status LED off" setting, so it always remains dark.

apgr commented 8 months ago

0% works, but the other settings all seem very bright. It is hard to see the difference

GitPetri commented 8 months ago

0% works, but the other settings all seem very bright. It is hard to see the difference

I think I saw the difference today (haven't had much time to play with the remote still) by booting up a dock, the initial led intensity was way higher that when the boot cycle ended so for me, yes looks like the 66% is just a display issue like @zehnm states above.

zehnm commented 6 months ago

Status update: fix has been released in the BETA group and will be released in the public OTA channel soon.

zehnm commented 6 months ago

Showing correct brightness setting is fixed in the just released version 1.6.4

spl237 commented 5 months ago

This is not fixed. On my remote and dock, both with the latest firmware, changes to LED brightness in the configurator and the remote claim to have saved, but on returning to the screen are seen to still be the same.