unfoldedcircle / feature-and-bug-tracker

Feature and bug tracker repository for Unfolded Circle products
22 stars 0 forks source link

[bug] Can not use "/" character in IR button name #187

Closed bikeymouse closed 7 months ago

bikeymouse commented 8 months ago

Is there an existing issue for this?

Description

If want to create a new remote button that has a name containing the "/" character, I can not save the button with the IR code. The interface responds with a "bad request" and gives no indication what is wrong.

slash-button

How to Reproduce

  1. Goto webconfig
  2. Click remotes
  3. Select remote
  4. Click pen-symbol on IR-data set
  5. Add a new name with a "/" in the box besides the "custom button" button
  6. Add an IR code or learn IR-code
  7. Click save

Expected behavior

Button should be saved or a proper error-resonse indicating what's wrong should be given.

System version

1.4.5

What part of the system affected by the problem?

Web Configurator

Additional context

No response

zehnm commented 7 months ago

Confirmed, a / character in the button name doesn't work for learning IR commands. This will be fixed in the next release.

The issue is only present on the remote device because of the reverse proxy. It decodes all encoded URLs by default and the reason we didn't caught it during development. Since the encoded IR command name is used in the URL as parameter, this then calls an unknown service endpoint. Instead of /api/remotes/:entityId/ir/test%2Ftest this was sent to the service: /api/remotes/:entityId/ir/test/test.

zehnm commented 7 months ago

Included in BETA release group and soon available.

zehnm commented 7 months ago

Fixed in v1.5.2