unfoldedcircle / feature-and-bug-tracker

Feature and bug tracker repository for Unfolded Circle products
21 stars 0 forks source link

[bug] Python integration On Sequence receives `"params": { "command": "send_cmd" }` #381

Closed ijc closed 1 week ago

ijc commented 3 weeks ago

Is there an existing issue for this?

Description

I have just published a Python integration for MythTV.

It mostly works well but when I try and use a simple command on an On/Off sequence instead of getting a message with the desired command I get:

{
  "kind": "req",
  "id": 5,
  "msg": "entity_command",
  "msg_data": {
    "cmd_id": "send_cmd",
    "entity_id": "mythtv",
    "entity_type": "remote",
    "params": {
      "command": "send_cmd"
    }
  }
}

Notice the "command": "send_cmd" which appears instead of whatever command was supposed to appear.

When a command is sent by a button (hard or soft) in the UI then it works.

How to Reproduce

Expected behavior

I expect the message received by the integration to contain the right command name somewhere, if not the "command" field then somewhere else.

System version

UI 0.42.1, core 0.43.0-beta, system 1.7.12

What part of the system affected by the problem?

Integration

Additional context

No response

zehnm commented 2 weeks ago

I'll check this tomorrow

ijc commented 2 weeks ago

Thanks! I did have a dig around in https://github.com/unfoldedcircle/remote-ui but that only appears to have v0.38.4 compared with 0.42.1 on the remote and in any case I failed to spot anything relevant.

zehnm commented 2 weeks ago

I'll check remote-ui as well, that should be up-to-date, otherwise we'll update it asap.

zehnm commented 2 weeks ago

Confirmed bug, I could reproduce it with the provided remote.py example in the Python integration driver.

As a workaround until a bugfix is released, the simple commands can be wrapped in a Send command:

image
ijc commented 2 weeks ago

Awesome, thanks for the workaround!

zehnm commented 2 weeks ago

Fixed in next release. A beta bugfix release is scheduled for tomorrow, a public release soon afterwards.

zehnm commented 1 week ago

Fixed in beta 1.7.13 and I'll close this issue once a public release is out.

zehnm commented 1 week ago

Part of 1.7.14