Light entity: fix color conversion & verify color mode conversion for brightness

unfoldedcircle / integration-home-assistant

Home-Assistant Integration for Remote Two

Mozilla Public License 2.0

27 stars 5 forks source link

Light entity: fix color conversion & verify color mode conversion for brightness #7

Closed zehnm closed 8 months ago

zehnm commented 1 year ago

Verify brightness handling / conversion.

The brightness is now also sent as color_mode which leads to the following error message in the integration: TODO light.theater_lights implement color mode conversion for color_mode: brightness. However, brightness setting is still working.

https://developers.home-assistant.io/docs/core/entity/light/

zehnm commented 8 months ago

The brightness, onoff and unknown color modes can be filtered out in the integration. They only generate log warnings.

What needs to be implemented is XY -> HS color mode conversion.

RGB* color modes need further investigation. I don't have any lights which return this color mode. Also, the automatic conversion in HA (through the WS API) is still a mystery :-) My Hue lights report XY color mode, but setting a color still works with the hs_color parameter.

zehnm commented 8 months ago

New insight: color change events from HA to the remote are broken:

only color_mode: hs is currently implemented, but HA seems to send xy by default. Also for Philips Hue.
There's a bug in the HS value extraction: saturation is scaled twice. Any value > 39 won't pass the value range check.

I start fixing it!