search

unfoldedcircle / integration-node-library

NodeJS API wrapper for the Unfolded Circle Integration API
Apache License 2.0
0 stars 2 forks source link

feat(#38): Introduce and use NVM (Node.js version manager) #40

Closed tinogo closed 1 month ago

tinogo commented 1 month ago

fixes #38

This PR introduces and uses NVM (Node.js version manager).

Unfortunately, after introducing NVM and installing the current NPM dependencies with Node.js v16.18, I've got the following warnings on the console:

grafik

i.e. the currently used Node.js by the Remote 2 is quite old and some of the required dependencies already require Node.js >= 18. So - I don't know how we wanna proceed here, @zehnm ? Maybe wait, until the next Beta Firmware has been released which features the updated Node.js runtime?

zehnm commented 1 month ago

Let's go ahead and bump the minimum requirement in .nvmrc to v20. The version mismatch seem to be all in dev dependencies and the included unit tests are quite simple. There's nothing which would test if the whole library runs correctly with v16.18. At the moment that's all done with manual testing on the Remote...

Please update .nvmrc and I'll merge the PR.

tinogo commented 1 month ago

@zehnm I've just pushed the change. :)