unfoldingWord-dev / Door43

old dokuwiki site
GNU General Public License v2.0
6 stars 11 forks source link

tN Hyphen Issues #430

Closed jag3773 closed 8 years ago

jag3773 commented 8 years ago

This is everywhere in tN that we have a note without a hyphen in it. These may not ​all​ be errors, but some of them are. For example, the two in Zep 2:6 are probably correct as is, however, the one in Zep 2:1 is probably missing a '-' after the bolded text. Check these locations in tS to see how they look there. The main difference is that if there is no hyphen then the bolded text shows up as the "reference text" and as the text of the note. If there is a hyphen then the bolded text only shows as the reference text and the rest of the note shows up as the text of the note. Let me know what your thoughts/comments are on this. If you can fix the ones that need fixing that will help a lot in the tN display in the app and elsewhere.

ChrisJarka commented 8 years ago

Jesse, I've gone through the list and corrected all the pages that are tagged publish. Can this query be run again on 1/15/16 and 1/31/16? I checked off what I did. If there is no check mark, then the chunk is not tagged publish.

ChrisJarka commented 8 years ago

Jesse - can you run this again some time this week?

jag3773 commented 8 years ago

@ChrisJarka Updated list:

Note: I generate this by running grep -re '\*\*.*\*\*' * | grep -v 'en:bible:' | grep -v '>>' | grep -v '<<' | grep -v '-' >/tmp/tN_missing_hyphens.txt from the notes directory. Then perform some substitutions to create the URLs and check boxes for the Github issue.

destatez commented 8 years ago

I ran the search again and found the following violation: (for the life of me I couldn't get the check-box, itself, to show on the Preview)

destatez commented 8 years ago

Jesse Chris was thinking that you guys had a Chron that would "fix" this. I run some weekly reports on Notes format errors, and found 55 instances where the space-hyphen-space syntax was not correct. Does this Chron need to be revised or is there another alternative from me doing GitHub global replaces to correct these when they are found? e.g. - for 2 spaces before hyphen rev\01\01.txt Line 55 > * General Information: - This is an introduction to the book of Revelation. It explains that it is a revelation from Jesus Christ and it gives a blessing to those who read it. rev\01\01.txt Line 56 > * his servants - the believers in Christ rev\01\01.txt Line 57 > * what must soon take place - "the events that must happen soon" rev\01\01.txt Line 58 > * made it known - "communicated it"

destatez commented 8 years ago

@jag3773 I ran my search reports today and cam up with several violations of the hyphen syntax in Notes. There are 2 that have the hypen clause totally missing, the other 2 have additioanl or missing spaces:

jag3773 commented 8 years ago

We do not have a cron for checking that @destatez .

destatez commented 8 years ago

A search for these conditions has been added to the weekly searches, with violations being passed to Chris J