search

unfoldingWord-dev / d43-catalog

Lambda functions for the Door43 Catalog.
https://api.door43.org/v3/catalog
MIT License
1 stars 8 forks source link

Issue 247: Write Signing Lambda Function #1

Closed phillip-hopper closed 7 years ago

phillip-hopper commented 7 years ago

Sign and verify functions, with tests Sign text and zip files on S3 Update in DynamoDB Improve coverage

This change is Reviewable

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 6dbfcdeb954c9d5ec09d31e3df10a900d334be15 on phillip-hopper:feature/Issue-247 into \ on unfoldingWord-dev:develop**.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 6f774a874ec0218ae84b366605f4c11e3ea4adc6 on phillip-hopper:feature/Issue-247 into \ on unfoldingWord-dev:develop**.

ethantkoenig commented 7 years ago

Review status: 0 of 25 files reviewed at latest revision, 3 unresolved discussions.

_functions/signing/signing.py, line 132 at r1 (raw file):_

Previously, phillip-hopper (Phil Hopper) wrote… > I did some digging, Although I couldn't find it documented. it appears the return code is zero for success and one otherwise. >

I'd rather not rely on non-documented behavior, but it seems that in either case that's what we'd be doing. I'd feel more safe relying on undocumented exit codes (somewhat hacky, but at least it's a widely used convention that 0 means success) as opposed to a string literal we expect to be printed to stdout (bigger hack, IMO).

Comments from Reviewable

richmahn commented 7 years ago

Reviewed 20 of 24 files at r1, 5 of 5 files at r2. Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

richmahn commented 7 years ago
:lgtm:

Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable