search

unfoldingWord-dev / d43-catalog

Lambda functions for the Door43 Catalog.
https://api.door43.org/v3/catalog
MIT License
1 stars 8 forks source link

Update fork lambda function to detect changes #29

Open jag3773 opened 7 years ago

jag3773 commented 7 years ago

@neutrinog commented on Wed Jul 05 2017

The fork lambda will detect new repositories in the catalog organization however it would add a layer of redundancy if it also check if there were changes to the commits.

We would need to simply compare the recorded commit id with that of the latest in DCS. This is blocked until the DCS api can be fixed to correctly return the branch information e.g. https://git.door43.org/api/v1/repos/Door43-Catalog/hi_ulb/branches

While logged into DCS the above api link works, however when not logged in gives a 401 response. Authentication should only be required to display sensitive information like email addresses or when the repository is private.

@neutrinog commented on Wed Jul 05 2017

I've updated the lambda to support checking for commit changes, however this will not actually work until the DCS api has been fixed.

@jag3773 commented on Thu Jul 06 2017

@ethantkoenig Are you aware of the bug @neutrinog referenced above? Is there a fix for it upstream?

@ethantkoenig commented on Thu Jul 06 2017

@jag3773 Not sure if it's a bug or requiring authentication was actually somebody's intent. I'll look into it.

@neutrinog commented on Thu Jul 27 2017

Just noting here that you can manually flag a repo as "dirty" within the aws console. In the d43-catalog-in-progress table simply change the dirty key on an item to true. This will cause the fork lambda to re-fetch the repository.

jag3773 commented 7 years ago

The DCS API should be fixed after October 5 ( https://app.zenhub.com/workspace/o/unfoldingword-dev/door43.org/reports?report=release&release=598b60210b69e7575d2be706 ).

jag3773 commented 4 years ago

Probably not blocked anymore now that we are on Gitea 1.12, but the issue might not be relevant anymore?