search

unfoldingWord-dev / ts-android

A tool to translate Bible stories into your own language
http://ufw.io/ts
Other
36 stars 19 forks source link

ts-android should export to USFM #1570

Open PhotoNomad0 opened 8 years ago

PhotoNomad0 commented 8 years ago

Instead of exporting in dokuwiki format, tS-android should be able to export in USFM format.

See https://github.com/unfoldingWord-dev/ts-requirements/issues/159 for more details

@klappy @neutrinog

cckozie commented 7 years ago

I don't know if this is a problem with the merge/conflict processing or the usfm export.

I started by importing the attached Philippians usfm file. I saved that project to door43 (user qa4). I deleted that project, reimported the usfm file, changed a couple of words in the first chunk, and went to the home screen. I them imported the previous project from door43 which created a conflict when the merge was done. I selected the text in the original version in the merge conflict dialog. I then exported that project to usfm attached below. In that file the verses are out of order and thus cause a problem when attempting to import that usfm file.

php_usfm.usfm.zip 1476373407216_en-x-demo2_PHP_Philippians.usfm.zip

PhotoNomad0 commented 7 years ago

@cckozie - I love the detail here. I followed your steps (made my changes in verse 1) but cant recreate the error in the USFM. On my device it imported back in correctly. I also tried exporting to USFM without resolving the merge conflict thinking that that would cause problems. But it seemed to be able to properly re-import the USFM file with the merge conflict. Can't explain the massive reordering of verses you saw.

I do see a bug that it is saving to internal memory rather than the SD card.

PhotoNomad0 commented 7 years ago

@cckozie - since I can't reproduce this with your test file and workflow, would you retest this make sure it is repeatable?

cckozie commented 7 years ago

@PhotoNomad0 Hmmm... I know I saw it at least twice in Orlando (I virtually never write anything up unless I can reproduce it at least once). However, today I am unable to reproduce the problem. Attached is the actual project file that produced the bad USFM output. When I attempt to import it into desktop it generates an error. Maybe by looking at the internals of the project you can see the problem and speculate on how it got that way.

1476890641_en-x-demo2_php_text_reg.tstudio.zip

cckozie commented 7 years ago

@PhotoNomad0 See details in issue #1659 on how to reproduce the problem of incorrect order of verses

da1nerd commented 7 years ago

@PhotoNomad0 has this been re-addressed?

PhotoNomad0 commented 7 years ago

@neutrinog - this has been fixed by sorting the chunks before output.

cckozie commented 7 years ago

This issue has been resolved as of build 144.