unfoldingWord-dev / ts-desktop

translationStudio Desktop App
http://ufw.io/ts
Other
41 stars 29 forks source link

rendering for poetry and headers - tS-Desktop v11.1 (build 128) #1147

Open ChrisJarka opened 7 years ago

ChrisJarka commented 7 years ago

It has come to our attention that the formatting of the source text for poetry that also has headers is not formatting correctly. Referring to Song of Songs/Solomon in particular.

Here is the USFM for SNG 1:1-5

\s5 \c 1 \p \v 1 The Song of Songs, which is Solomon's. \sp The young woman speaking to her lover \q \v 2 Oh, that you would kiss me with the kisses of your mouth, \q for your love is better than wine. \q \v 3 Your anointing oils have a delightful fragrance; \q your name is like flowing perfume, \q so the young women love you. \q \v 4 Take me with you, and we will run. \sp The woman speaking to herself \q The king has brought me into his rooms. \sp The woman speaking to her lover \q I am glad; I rejoice about you; \q let me celebrate your love; it is better than wine. \q It is natural for the other women to adore you.

\s5 \sp The woman speaking to the other women \q \v 5 I am dark but lovely, \q you daughters of Jerusalem's men— \q dark like the tents of Kedar, \q lovely like the curtains of Solomon. \q

As seen in this screen capture of the full source text - the hard line breaks are NOT rendered correctly and the phrase of "The young woman speaking to her lover" is not on a separate line nor italicized as expected from the USFM markers.

solomon full tsdesktop

Here is a screen shot of the 3-column view showing the same. Also note that the phrase "The woman speaking to the other women" before verse 5 is in the previous chunk even tho it does come after the \s5 marker.

solomon cards tsdesktop

cdwhitfield73 commented 7 years ago

Yes, you are correct.

To be clear, there is NO formatting whatsoever being added to the source text for any markers. Paragraphs, line breaks, quotes, etc. are all being ignored (and always have been) except for verse markers. There has never been an issue, before now, written up to add any such formatting. Also, please note that we do not receive the USFM text in the app. It is converted to USX by the web team before we see it. So I don't know how all of these markers are converted. Another thing to remember is we no longer use the S5 marker at all for chunking. Chunks are simply defined by verse range and all text is considered to be part of the previous verse marker, so headers to a verse or chunk as you mentioned that are outside the verse marker will not show up as expected. This is all stuff that will need to be addressed in a future release.