unfoldingWord / bible-reference-rcl

Bible Reference Navigation RCL
https://unfoldingword.github.io/bible-reference-rcl/
Other
0 stars 2 forks source link

Settings popups should close when the user clicks away #24

Closed PhotoNomad0 closed 3 years ago

PhotoNomad0 commented 3 years ago

When the user opens card settings the settings don't seem to be attached to the three dot icon - they tend to show up in center of screen. Settings popups should be closed when the user clicks outside of the popup.

DoD: A settings card, invoked from the 3 dot menu, will close when the user clicks outside of the settings card.


Also they are modal which means you can't interact with rest of screen. So we need to do one of

birchamp commented 3 years ago

@PhotoNomad0 since the settings popup can change how the content is shown in the cards, I don't want to dim. So we will have the popup close when you click off of it. I've changed the issue to reflect that.

cckozie commented 3 years ago

Settings popups close when the user clicks away in v0.2.0 build cbad9c9

elsylambert commented 3 years ago

Works as expected in v0.9.0 build ab13659.