PhotoNomad0
commented
1 year ago Notes:
- using the diff package I can generate a diff such as:
Index: 57-TIT.usfm
===================================================================
--- 57-TIT.usfm
+++ 57-TIT.usfm
@@ -9,9 +9,9 @@
\\ts\\*
\\c 1
\\p
-\\v 1 \\zaln-s |x-strong="G39720" x-lemma="Παῦλος" x-morph="Gr,N,,,,,NMS," x-occurrence="1" x-occurrences="1" x-content="Παῦλος"\\*\\w Paul|x-occurrence="1" x-occurrences="1"\\w*\\zaln-e\\*,
+\\v 1 EDITED verse: \\zaln-s |x-strong="G39720" x-lemma="Παῦλος" x-morph="Gr,N,,,,,NMS," x-occurrence="1" x-occurrences="1" x-content="Παῦλος"\\*\\w Paul|x-occurrence="1" x-occurrences="1"\\w*\\zaln-e\\*,
\\zaln-s |x-strong="G14010" x-lemma="δοῦλος" x-morph="Gr,N,,,,,NMS," x-occurrence="1" x-occurrences="1" x-content="δοῦλος"\\*\\w a|x-occurrence="1" x-occurrences="1"\\w*
\\w servant|x-occurrence="1" x-occurrences="1"\\w*\\zaln-e\\*
\\zaln-s |x-strong="G23160" x-lemma="θεός" x-morph="Gr,N,,,,,GMS," x-occurrence="1" x-occurrences="2" x-content="Θεοῦ"\\*\\w of|x-occurrence="1" x-occurrences="5"\\w*
\\w God|x-occurrence="1" x-occurrences="2"\\w*\\zaln-e\\*- I was able to get it to work in swagger by:
- created a js function to create a patch file using the
diffmodule. Then I had to escape certain characters to make the content compatible with json (prefixed these with a backslash:\, newlines,") - I did get back a 201 code (expected a 200). But it created the user branch and created a commit with just the changes.
- created a js function to create a patch file using the
danielklapp
elsylambert
The delay for changing a verse is excessively long. Saving a verse should be less than 6s in Psalms. Rich has suggested sending a patch. Or it could be done as a background task, but that brings complications with failed saves. Rich suggests https://git.door43.org/api/swagger#/repository/repoApplyDiffPatch
DoD:
Saving an edited verse (both text and alignment edits) in Psalms completes the task in less than 6 seconds.