unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

Highlighting breaks when Occurrence number is changed #535

Closed elsylambert closed 10 months ago

elsylambert commented 1 year ago

Highlighting breaks when Occurrence number is changed on tN card for multiple occurrences of a word.

Updating to the latest scripture-resources-rcl is the first step to fixing this, but some changes may be necessary in the single-scripture-rcl.

DoD:

Highlighting multiple occurrences works the same as tC based on the occurrence number.

Details:

Highlighting should follow the logic outlined on the D43 forum: https://forum.door43.org/t/parascriptural-tab-separated-value-format-specification-v2/870

birchamp commented 1 year ago

@PhotoNomad0 @kintsoogi @abelpz I thought we had done a highlighting library that could be used in multiple apps. Is that being used here?

abelpz commented 1 year ago

@birchamp looks like gateway-edit is not using the latest version of scripture-resources-rcl which handles highlighting.

birchamp commented 1 year ago

@elsylambert please test this same issue in tCC.

elsylambert commented 10 months ago

v2.2.0 build 3179311 QA. Highlights work fine in scripture resources when Occurrence number is changed in tNotes.

Screenshot 2023-12-04 at 5.13.33 PM.png