Move Add Button in TWL to Action Row

[kintsoogi]

The add TSV button for the Translation Word List resource should be within the table, not within the card header

Example Private Zenhub Image

[kintsoogi]

Describe what your pull request addresses

• [ ] Add TSV button to add another tsv resource

Test Instructions

• [ ] Open deploy preview
• [ ] Click on the add button on any of the TSV Resource cards
• [ ] Enter contents to add tsv item and click submit
• [ ] Click on the save button of the card that you edited
• [ ] Click on the next tsv item and verify that your TSV item has been added.
• [ ] Repeat this process for creating a tsv item in another verse and for a resource that does not currently have any TSVs
• [ ] Verify that TSV List Add button generates within the "Actions" column of the table and not in card header
• [ ] Verify that Support Resource in Translation Notes Add Dialog has a list of links to select from

[elsylambert]

@kintsoogi is this change merged in Develop branch?

[kintsoogi]

@kintsoogi is this change merged in Develop branch?

Yes it is!

[elsylambert]

v2.1.0 build f845565 QA on https://develop--gateway-edit.netlify.app/. Seeing a number of problems:

1. When we click on TWL row + to add a row, the add row dialog shows a different verse in Reference and the Original Quote.

Private Zenhub Image

Private Zenhub Image

2. When in OT books, the Original Quote field is empty. Private Zenhub Image

3. After we click on Add on Add row dialog, the changes are saved in a different verse due to problem mentioned in Step 1.

[birchamp]

@elsylambert @kintsoogi we should only fill in the new reference, new id, occurrence, and a dropdown for the TWs.

[birchamp]

@elsylambert @kintsoogi let's break out the dropdown as a separate issue.

[elsylambert]

@birchamp I rewrote the issue #506 and moved to Backlog. This issue defines the drop-down for new rows for TWLs.

[kintsoogi]

@danielklapp @elsylambert

This fix is ready in develop now!

Describe what your pull request addresses (Please include relevant issue numbers):

• [ ] Only generate new TSV Row for add dialog on add button click (Gateway Edit #577)
• [ ] Add checking for tsvs object and for TSV Row for new/updated row (Gateway Edit #577)
• [ ] Show correct reference when user clicks on Add TSV (Gateway Edit #542)
• [ ] Correctly generate ID (Gateway Edit #578)

Please include detailed Test instructions for your pull request:

• [ ] Deploy Preview
• [ ] Navigate to Titus 1:1 on Test_Org En (I input a wrong TSV Item)
  • [ ] Click the add button on TN
  • [ ] Verify that app does not crash
• [ ] Navigate to a different verse than the one you started on and click add button
  • [ ] Verify that the reference column is filled in with the correct verse!
• [ ] Click the add button in TN, TQ, and TWL to verify that random IDs are being generated for each resource

[danielklapp]

When clicking on Add Tsv Row button under Actions, the add row dialog does show correct verse in Reference and the Original Quote. Looks good with v2.1.0 build 65fd995 QA.

[elsylambert]

Add row in TWL looks good in v2.1.0 build 19c7052 QA. The newly added row shows correct reference and saves in the right resource and Reference. Note: However, every new row we add, the add row Modal shows the very first TWL rc link in the file for e.g if Paul is the first TW in the TSV file, rc link rc://*/tw/dict/bible/names/paul ia autofilled in TWL link field. So every time a new row is added, user must type in TWL link in order to add a different word other than Paul. This issue would be addressed by #506 when drop-down for Links would be made available.