unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

Reference Range Capability for Add TWL #545

Closed kintsoogi closed 5 months ago

kintsoogi commented 1 year ago

The user should be able to edit the reference field during the add process to any allowable reference - both single references and reference ranges

DoD

Adding a row with a reference range functions as a single reference does.

birchamp commented 10 months ago

Seems to be working in TN

kintsoogi commented 10 months ago

When we add a TSV in a resource, we then immediately reload that TSV resource. During this reload, the fetching function will take the newly created Reference range and propagate it to all references within our book.

All that being said, adding a reference range should already be working! We have some checks when adding to make sure input reference is valid, but this check also accounts for valid reference ranges!

kintsoogi commented 10 months ago

To Test

danielklapp commented 10 months ago

Scripture card shows both types of reference ranges. When navigating to either reference, the tsv item is there. Tested with v2.3.0 build bd4a646 QA

Screenshot 2023-12-20 at 12 40 52 AM Screenshot 2023-12-20 at 12 41 58 AM