search

unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

Need to add support for aligning chapter headers/front matter to GWE #559

Closed PhotoNomad0 closed 10 months ago

PhotoNomad0 commented 1 year ago

Need to add support for aligning chapter headers/front matter to tCore. This is especially needed for Psalms alignment.

In Psalms there is chapter headers/front matter that is in the original language that needs to be aligned.

Not sure if any other book have this need.

This is directly related to https://github.com/unfoldingWord/translationCore/issues/7536

DoD

Users can align scripture text under the \d marker.

PhotoNomad0 commented 1 year ago

@birchamp @elsylambert A few options here in handling error conditions when user clicks align:

  1. we can add separate warning dialogs:
    • There are no align-able words in the target language
    • There are no align-able words in the original language
  2. we can add single warning dialog for when either target language or original language does not have align-able words

It would probably be less confusing to user to do option 1 (my recommendation).

And what message should we show on the error?

elsylambert commented 12 months ago

I would suggest option 1.

Case I: When the Scripture text do not have words to align, the message could be "There are no words to align in the Literal/Simplified Scripture Text" Case II: When Original language does not have words to align, the message could be "There are no words to align in the Original language"

PhotoNomad0 commented 12 months ago

@birchamp @elsylambert It was suggested that when navigating by chapter or book that we default to verse 1 and not front.

PhotoNomad0 commented 11 months ago

@elsylambert Merged the code into develop branch, but seeing a strange runtime bug when it shows an alignment error and use clicks cancel. Looking into it:

Screenshot 2023-11-01 at 1 20 52 PM
PhotoNomad0 commented 11 months ago

@danielklapp ^^^

PhotoNomad0 commented 11 months ago

I was able to reproduce this in a debug build of the develop branch. I see a clue as to what is going on:

Screenshot 2023-11-01 at 3 38 18 PM
PhotoNomad0 commented 11 months ago

@kintsoogi I was able to narrow this down to being a crash in 'ta' resources.

PhotoNomad0 commented 11 months ago

@elsylambert - This should be working in latest develop build

elsylambert commented 11 months ago

Front matter support looks good in v2.1.0 build f845565 QA. By default the navigation is done to verse 1, but verse dropdown as Front option in the top. It enables users to align front matter. Private Zenhub Image

Private Zenhub Image

elsylambert commented 11 months ago

@PhotoNomad0 I wrote highlighting issue separately in #579. Highlighting is not working for front matter.

danielklapp commented 11 months ago

I got the same results as stated above. Front matter support looks good to me and was tested with v2.1.0 build f845565 QA.