search

unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

ID not generated for TQ if not there are not many TQs #563

Closed kintsoogi closed 9 months ago

birchamp commented 10 months ago

@kintsoogi we need more definition on this. What does "not many" mean?

kintsoogi commented 9 months ago

@birchamp @elsylambert Alright, I researched this some and I think I figured out what the problem is.

The need to generate a random ID is based off of whether or not the values for a certain TSV column are unique. Right now in some books, there are multiple translation questions that have the same ID (i.e the book of matthew in QA). For this book of Matthew, only about 450/650 rows have unique IDs

This is problematic:

  1. I assume that resources are not supposed to have multiple IDs that are the same
  2. A random ID will not be generated on add if row values for a column are not unique (our problem)
birchamp commented 9 months ago

@kintsoogi a while back we had this problem in tCC. @mandolyte wrote code to prevent TSVs with duplicate IDs from being opened. But the users then have to go back and replace the ids with made up numbers. In that case should we just fix the bad Ids dynamicaly?

PhotoNomad0 commented 9 months ago

@birchamp @kintsoogi - at one point we only required there to be unique ids for each verse reference. But then we later started tightening those requirements. I think @mandolyte worked on that effort.

PhotoNomad0 commented 9 months ago

@birchamp Probably should warn users before id's are update dynamically and give them the option to cancel that.