Get 500 error on saving changes

unfoldingWord / gateway-edit

Book Package harmonized view.

https://gatewayedit.com

MIT License

1 stars 4 forks source link

Get 500 error on saving changes #564

Closed PhotoNomad0 closed 8 months ago

PhotoNomad0 commented 10 months ago

Users sometimes get 500 error on saving changes. See screenshot below:

~~Seems this problem appears when there is just a small whitespace change - the library that generates the patch creates an empty patch that DCS does not like.~~

abelpz commented 10 months ago

I can confirm this is happening to us too @PhotoNomad0, it has happened with three different verses, and with bigger changes too.

elsylambert commented 10 months ago

@danielklapp To be tested on Develop link.

PhotoNomad0 commented 10 months ago

@elsylambert @danielklapp This should be fixed in latest develop.

danielklapp commented 10 months ago

@PhotoNomad0 Not getting the 500 error but getting Network Error with code 401 on saving. Here's attached console log develop--gateway-edit.netlify.app-1699592392751.log. Tested with v2.1.0 build e2d994b QA

elsylambert commented 10 months ago

Tried to save ULT on develop link. First save looked good, but then saved a whitespace and this error showed up as Manifest failed to load Private Zenhub Image

PhotoNomad0 commented 9 months ago

@elsylambert @danielklapp This is likely happening when there is a problem reloading the verse. The app gets stuck thinking the changes are not saved. Unfortunately not having a reliable way to reproduce this is hindering progress on a solution.

PhotoNomad0 commented 9 months ago

Notes - the 500 error can happen if

patch is empty
patch does not match the repo due to:
- wrong file sha
- patch not compatible with original file

Options:

on error refetch book from repo and get latest file sha
check to see if latest file data was already applied
if latest data was not saved, generate new patch and try again using latest file sha.

Testing a fix to retry sending data if an error is detected.

elsylambert commented 9 months ago

While testing #565, I found saving error in ULT while saving the alignment. Private Zenhub Image

PhotoNomad0 commented 9 months ago

While testing #565, I found saving error in ULT while saving the alignment. Private Zenhub Image

I think there is another issue for that error. 401 errors are typically when you are no longer logged in.

PhotoNomad0 commented 9 months ago

@elsylambert @danielklapp This is fixed in GWE v2.1.0 build 19c7052

elsylambert commented 9 months ago

Not seeing 500 error in v2.1.0 build 19c7052 QA while saving ULT/UST.

danielklapp commented 9 months ago

Agree that I'm not getting 500 error while saving. Tested with v2.1.0 build 19c7052 QA.