Add Alignment validation and migration to each verse

unfoldingWord / gateway-edit

Book Package harmonized view.

https://gatewayedit.com

MIT License

1 stars 4 forks source link

Add Alignment validation and migration to each verse #565

Closed PhotoNomad0 closed 10 months ago

PhotoNomad0 commented 12 months ago

This is split out of issue https://github.com/unfoldingWord/gateway-edit/issues/562 - will leave the other issue open until we can determine how to reproduce the corruption seen.

Tasks to do:

[ ] on first navigation to a verse, the alignment indicator will show broken if target words are aligned to an original word not found in the original language bible
[ ] on click to open alignments, existing alignments will be migrated to match latest original language and falling back to normalized matching if exact word match not found. Any alignments to original language words not found in the original language bible will be removed.
[ ] after verse edit, existing alignments will be migrated to match latest original language and falling back to normalized matching if exact word match not found. Any alignments to original language words not found in the original language bible will be removed.

PhotoNomad0 commented 11 months ago

@elsylambert @danielklapp - This is now in GWE v2.1.0 build f845565. Still working on a way to test...

PhotoNomad0 commented 11 months ago

@elsylambert @danielklapp OK have a way to test on qa server using test_org/en. I made some changes in the master branch on qa (so testing should work for this week)

in Gal 1:1 I modified the alignment word for Peter which makes the original alignment invalid. So when you go there you should see an invalid alignment icon:

then click the alignment icon and should see Peter not aligned:

in Gal 1:2 I modified the alignment word for borthers (and the lemma) which makes the original alignment invalid. So when you go there you should see an invalid alignment icon:

then click the alignment icon and should see brothers not aligned:

danielklapp commented 11 months ago

@PhotoNomad0 is there a DOD for this issue?

elsylambert commented 11 months ago

Verified in v2.1.0 build f845565 QA with the test steps provided, alignment validation works as expected. However, I found the saving error when I tried to save the alignment for "Brothers" in the second step, will update it in #564

Private Zenhub Image

danielklapp commented 11 months ago

@PhotoNomad0 in testing the steps yesterday I was thinking I was missing something. I've retested alignment validation and it's working properly. Tested with v2.1.0 build f845565 QA.