unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

Save to DCS on TSV Add & Navigate to new TSV Row #571

Closed kintsoogi closed 10 months ago

kintsoogi commented 10 months ago

Describe what your pull request addresses

Test Instructions

codecov[bot] commented 10 months ago

Codecov Report

Merging #571 (76db770) into develop (af6952c) will increase coverage by 0.53%. Report is 1 commits behind head on develop. The diff coverage is 52.63%.

:exclamation: Current head 76db770 differs from pull request most recent head 5e71fc7. Consider uploading reports for the commit 5e71fc7 to get more accurate results

@@             Coverage Diff             @@
##           develop     #571      +/-   ##
===========================================
+ Coverage    51.52%   52.05%   +0.53%     
===========================================
  Files           43       43              
  Lines         1312     1314       +2     
===========================================
+ Hits           676      684       +8     
+ Misses         636      630       -6     
Files Coverage Δ
src/components/BibleReference.js 75.00% <ø> (ø)
src/components/WordAlignerDialog.js 44.44% <100.00%> (+2.13%) :arrow_up:
src/components/WorkspaceContainer.js 63.49% <100.00%> (ø)
src/components/ResourceCard.js 66.94% <47.05%> (+1.13%) :arrow_up:

... and 2 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

PhotoNomad0 commented 10 months ago

@kintsoogi - seeing a bug with twl. I added a row, but the save icon did not turn black to show there are unsaved changes. And then I was able to navigate to a new verse without being prompted to save.

PhotoNomad0 commented 10 months ago

@kintsoogi Also seeing a problem when I add a tNote: as soon as I clicked add, it did an automatic save of the new note.

kintsoogi commented 10 months ago

@kintsoogi Also seeing a problem when I add a tNote: as soon as I clicked add, it did an automatic save of the new note.

@PhotoNomad0 I think both of those situations are a part of the feature and goal of this PR! This is a PR to remove the need to press the save button after adding a TSV resource