Crash Navigating to tit on test_org/en

[PhotoNomad0]

using GWE v2.1.0 build f845565 QA - When I set organization to test_org and language to en, it opens to Matthew. But when I change the book to tit, I see this crash:

Private Zenhub Image

[PhotoNomad0]

It seems quite reproducible.

[PhotoNomad0]

@kintsoogi This is the problem we saw before:

It looks like there is a problem that someone did a hand edit on one of the lines:

Should probably make the code more rugged so we don't crash on invalid tsv lines.

Another issue seems to be that this function is being called repeatedly even when we are not adding a row. In this case, if we do a refresh we hit this error before rendering even begins.

[kintsoogi]

@PhotoNomad0 Going to be working on this today!

[kintsoogi]

@danielklapp @elsylambert

This fix is ready in develop now!

Describe what your pull request addresses (Please include relevant issue numbers):

• [ ] Only generate new TSV Row for add dialog on add button click (Gateway Edit #577)
• [ ] Add checking for tsvs object and for TSV Row for new/updated row (Gateway Edit #577)
• [ ] Show correct reference when user clicks on Add TSV (Gateway Edit #542)
• [ ] Correctly generate ID (Gateway Edit #578)

Please include detailed Test instructions for your pull request:

• [ ] Deploy Preview
• [ ] Navigate to Titus 1:1 on Test_Org En (I input a wrong TSV Item)
  • [ ] Click the add button on TN
  • [ ] Verify that app does not crash
• [ ] Navigate to a different verse than the one you started on and click add button
  • [ ] Verify that the reference column is filled in with the correct verse!
• [ ] Click the add button in TN, TQ, and TWL to verify that random IDs are being generated for each resource

[danielklapp]

Not seeing this issue of crashing. Looks good with v2.1.0 build 65fd995 QA.