Bug in delete row when row is at the end of the book

[elsylambert]

https://github.com/unfoldingWord/gateway-edit/assets/14238574/f34ccc91-df8f-442c-a0f1-e889ffd0af2f It is related to adding the tN to the end of the book. It's throwing an exception.

[kintsoogi]

This is happening when a tsv item is added at the very end of a book and it is the last tsv items in tsv items.

For some reason, when we get the tsvs back from DCS after adding, we receive and undefined Note value in the very last element.

Note is the last element in the TN tsv files, so I'm guessing something is happening when we are parsing the TSV file that we are receiving from DCS. I bet that we are looking at it and seeing that there's nothing at the end of the file for note, so we are passing an undefined value

This is not happening in useTsvItems, because the content array that we receive from useRsrc() has the item with the undefined note already. It must be happening in scripture resources rcl.

[kintsoogi]

Aha! This was happening in tsvToJson in scripture-resources-rcl. When the last item in a tsv was empty, the split() funciton would not add a value to the array of TSV row values, and so that property was being set to undefined. In our case, this property was the note property.

[kintsoogi]

@elsylambert @danielklapp

Test Instructions

• [ ] Open Deply Preview
• [ ] Navigate to the very last verse in a book.
• [ ] In translation notes, navigate to the very last item by using the right arrow button.
• [ ] Add a new EMPTY tsv item (at current reference). Make sure not to put anything in the note field!
• [ ] In the newly created note, edit all of the fields and make sure the changes are reflected.
  • [ ] Verify that no major errors have been thrown
  • [ ] Clicking delete, verify that the note information is shown in the delete dialog

[danielklapp]

After following test instructions, edits made are reflected in all the fields. Not seeing any major errors but an occasional 409 error in the console. When looking at the delete dialog it shows all the note information. Tested with v2.2.0 build 7018555 QA.

[elsylambert]

v2.2.0 build 7018555 QA. Not seeing error when a new row is added at the end of the book.