Delete TWL that includes a Reference Range

[birchamp]

When deleting a row with a reference range the user should be able delete that row the same as a single verse row.

DoD

Deleting any TWL should remove the row from the TSV.

[kintsoogi]

Problem: TSV items with reference ranges are still being displayed in the current reference when we try to delete them.

Why: Our code in handling the deletion of our item in the TSV state for the current reference. However, on delete we are also updating our user branch with new TSV content. When this happens, we remove all reference range notes except one and upload the new TSVs content to DCS. Since we are not deleting the reference range notes at the other references in the TSVs state, this note with a refrence range is still added to DCS. So, wehen we reload our content (which happens on delete), the reference range item gets populated right back into our current reference!

Solution: We need to make sure to delete the TSV reference range note from all references in the TSV state! Then the ref range TSV item will also be deleted from DCS on delete and not repopulate!

[kintsoogi]

@elsylambert @danielklapp This issue is in Develop c6612ba

Describe what your issue addresses

• [ ] Provide the ability to delete a reference range within a TSV resource.

Test Instructions

• [ ] Open Deploy Preview
• [ ] In a valid TSV resource (TN is easiest to see), create a new TSV item with a reference range (i.e 1:1-4 OR 1:1;3:2).
  • [ ] Navigate to another verse within your reference range to verify that your TSV item shows at that reference.
• [ ] In any of the verses within the reference range you created, delete the new item with the reference range.
  • [ ] Navigate to another verse within your reference range to verify that your TSV item DOES NOT SHOW at that reference.

[elsylambert]

v2.3.0 build bd4a646 QA. Delete row that has a refernce range works fine, but I found that the Delete row dialog has this text:

[elsylambert]

Moving this issue to QA fail for your attention @kintsoogi The feature looks good but only needs fix for the text shown in the modal ^^.

[kintsoogi]

Moving this issue to QA fail for your attention @kintsoogi The feature looks good but only needs fix for the text shown in the modal ^^.

A fix should have just gone in to fix it! ef6f5fc

Test Instructions

• [ ] Open Deploy Preview
• [ ] Create a new translation note with a reference range (i.e 1:1-4 OR 2:3;3:4)
  • [ ] Once the new note is created and the app has navigated there, click on the delete button
  • [ ] Verify that the _referenceRange section of the dialog no longer shows

[elsylambert]

Looks good in v2.3.0 build 06539c8 QA. Not seeing _refernceRange in delete dialog box.

[danielklapp]

Not seeing _referenceRange under the Note in Delete This TSV Item? window. Tested with v2.3.0 build 06539c8 QA.