Save button is enabled when edit box is clicked

unfoldingWord / gateway-edit

Book Package harmonized view.

https://gatewayedit.com

MIT License

1 stars 4 forks source link

Save button is enabled when edit box is clicked #602

Closed elsylambert closed 8 months ago

elsylambert commented 9 months ago

v2.2.0 build 7018555 QA On UST/ULT or other resource cards, when user clicks in the edit box to edit save button is enabled before any edits are made.

Click on the ULT resource card edit box.
Note that save button is enabled.
Click out of the box without making any edit and note that the Save button is still enabled.
Navigate to next verse from the top navigation bar and browser throws warning that changes are not saved.
Click on Save button and it does not Save. Note that the console shows Nothing to save.

Private Zenhub Image

DOD: If the user has not made any edits, Save button should not get enabled.

kintsoogi commented 9 months ago

@PhotoNomad0

This issue was introduced in Gateway Edit Commit f845565 Single-scripture-rcl version 3.4.14

I hunted it down and figured out that in setEditing in useScriptureAlignmentEdit, it's thinking that the intial and updated verse objects are different ONLY because they have an endTag: "zaln..." field.

Because of this difference, it is indicating that is has saved changes and the button becomes enabled

PhotoNomad0 commented 9 months ago

@kintsoogi Have a fix for this now.

PhotoNomad0 commented 9 months ago

@elsylambert @danielklapp The fix is in release branch v2.2.0 build 6765008 QA

elsylambert commented 9 months ago

Looks good in v2.2.0 build 3179311 QA. Not seeing save button enabled when text box is clicked.

danielklapp commented 9 months ago

Looks good to me. Tested with v2.2.0 build 6765008 QA.