unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

bugfix 548 / fix for invalid user token #611

Closed PhotoNomad0 closed 9 months ago

PhotoNomad0 commented 9 months ago

Describe what your pull request addresses

Test Instructions

codecov[bot] commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c6612ba) 51.64% compared to head (a5aa5bc) 50.56%.

Files Patch % Lines
src/context/AuthContext.js 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #611 +/- ## =========================================== - Coverage 51.64% 50.56% -1.09% =========================================== Files 43 43 Lines 1336 1339 +3 =========================================== - Hits 690 677 -13 - Misses 646 662 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PhotoNomad0 commented 9 months ago

LGTM, seems to work as it should. If you don't close the app before switching, come back, and make an edit, it throws an error but that is to be expected.

@kintsoogi Yes, there is a second part that will need to be done eventually to completely fix the issue: When there is 401 error on edit - the popup should tell you that you are no longer logged in and give you the option of going to login screen. But that may get complicated due to the warning about unsaved changes.