unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

Site crashes after adding new translation note row with a reference range #637

Closed danielklapp closed 4 months ago

danielklapp commented 9 months ago

When user creates a new translation note row that has reference range with an existing chapter&verse that’s in a book, and chapter&verse that doesn’t exist in that book. The row shows up in translationNotes, but when clicking on previous or next button the site crashes.

Example :

Screenshot 2024-01-05 at 10.49.51 AM.png

v2.3.0 build 06539c8 QA

danielklapp commented 9 months ago

@kintsoogi I updated the steps to replicate this issue.

kintsoogi commented 9 months ago

@danielklapp @elsylambert Fix for this is in develop build 8faf60b

elsylambert commented 8 months ago

v2.3.0 build 8f589a0 QA. Not seeing a crash when an invalid Reference is entered in the reference field. It does not create a row in such case. We can see error in the console for invalid row input.

danielklapp commented 8 months ago

Invalid new row input error is shown in console when user types an invalid reference. Invalid row isn't created and site not crashing when navigating the next and previous buttons. Looks good and tested with v2.3.0 build 8f589a0 QA.