Highlight breaking for a verse bridge

[elsylambert]

Describe the bug Punctuation like semicolon, at the end of a verse is breaking highlight for a verse bridge

To Reproduce Steps to reproduce the behavior:

1. Go to 3Jn 1:7, Note that there is a semicolon at the end of verse 6.
2. Note that there is no highlight shown.
3. Add a "&" between 6 and 7 verses, highlight shows up.

Expected behavior Highlight should not break when there is a punctuation in a verse bridge.

Screenshots Problem:

After adding "&":

This was working fine in #395 in v2.0.0 build a2a20c1.

[elsylambert]

@PhotoNomad0 Would you please review Abel's PR.

[PhotoNomad0]

@elsylambert None of the image links work in the description

[PhotoNomad0]

@elsylambert This will be in the latest develop branch when build completes.

[elsylambert]

Not seeing the highlights for verse bridge in v2.4.0 build 4b01301 QA.

[PhotoNomad0]

I cannot open this image. Sent from my iPhoneOn May 16, 2024, at 9:14 AM, elsylambert @.***> wrote: Not seeing the highlights for verse bridge in v2.4.0 build 4b01301 QA.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: @.***>

[PhotoNomad0]

@elsylambert - None of the image links open up. I just get an URL such as https://camo.githubusercontent.com/24e507a555cfa0bd4838319b26fef2f3e3b21256324d751084324fa5f73c2cf9/68747470733a2f2f6170692e7a656e6875622e636f6d2f617474616368656446696c65732f65794a66636d467062484d694f6e73696257567a6332466e5a534936496b4a42614842424d464657516b453950534973496d563463434936626e56736243776963485679496a6f69596d7876596c39705a434a3966513d3d2d2d656137656665326333396432393233306438373236333432616437623662323861346532306537332f53637265656e73686f74253230323032342d30332d32372532306174253230392e30342e3537254532253830254146414d2e706e67 that says no found.

OK, now they they are replaced with links that say private zenhub image - I still cannot open them.

[PhotoNomad0]

@elsylambert this is what I am seeing. Highlight seems to be working for UST which is a verse span, but not for ULT which has separate verses.

[elsylambert]

Older version:

Latest version:

[elsylambert]

@PhotoNomad0 Hope the above screenshot is visible ^^. This is how it was showing in earlier versions of GWE. v2.0.0 build a2a20c1. To view: https://release-v2-0-0--gateway-edit.netlify.app/

Now it does not show highlights in UGNT and ULT Note that Original Quote in TN card is not highlighted when there is a punctuation between the verses. I have also added the screenshot on discord if it does not show here.

[PhotoNomad0]

@PhotoNomad0 Hope the above screenshot is visible ^^. This is how it was showing in earlier versions of GWE. v2.0.0 build a2a20c1. To view: https://release-v2-0-0--gateway-edit.netlify.app/

Now it does not show highlights in UGNT and ULT Note that Original Quote in TN card is not highlighted when there is a punctuation between the verses. I have also added the screenshot on discord if it does not show here.

@elsylambert Still not able to see any of your image links, but it see that it was working in GWE 2.1.0 release, but not in the GWE 2.2.0 release.

@abelpz

[PhotoNomad0]

@elsylambert @danielklapp - this issue is fixed in develop build v2.4.0 build 542041b.

[elsylambert]

Looks good in v2.4.0 build 542041b QA. Highlighting works for a verse bridge.

[danielklapp]

@PhotoNomad0 testing with v2.4.0 build 542041b QA, I noticed under translationNotes card just by clicking on the Quote you can turn highlighting on and off.

[PhotoNomad0]

Note:

The problem occurs because there is a logic error here: https://github.com/unfoldingWord/translation-helps-rcl/blob/main/src/components/TsvContent/TsvContent.jsx#L222

Whenever the user clicks on the quote, and there is already a selection, then setCurrentCheck(null) is called which clears the current selected quote in GWE. This is a pre-existing logic error exposed by fixing verse range support.

[PhotoNomad0]

@danielklapp @elsylambert This should be fixed in develop build v2.4.0 build 21d9af9

[elsylambert]

Looks good in v2.4.0 build 21d9af9 QA. Not seeing highlighting breaking when Quote is clicked on tN card.

[danielklapp]

Highlighting is working for verse bridge and not seeing highlighting toggling on and off when clicking Quote in the translationNotes card. Tested with v2.4.0 build 21d9af9 QA

[PhotoNomad0]

@danielklapp @elsylambert Found that I had incorrectly published the translation-helps-rcl - this should not be working in develop: v2.4.0 build b12a481

[elsylambert]

Looks good in v2.4.0 build adfde3f QA. Highlighting works fine for verse bridges.