unfoldingWord / gateway-edit

Book Package harmonized view.
https://gatewayedit.com
MIT License
1 stars 4 forks source link

Original language word lost when one word is split from a group of words #643

Open elsylambert opened 3 months ago

elsylambert commented 3 months ago

When splitting original words, one of the original words gets lost.

Bug_Alignment_Splitting_Orignal_Words.gif
elsylambert commented 2 months ago

@PhotoNomad0 here is the issue for Aligner bug where a word is lost when split from a group of words.

PhotoNomad0 commented 2 months ago

@elsylambert Do you have an example for this?

elsylambert commented 2 months ago

@PhotoNomad0 In es-419_gl org and lang as es-419, go to Jonah 1:1 in Texto Puente Literal, open aligner. In Jonah 1:1 we have a word that is merged, it is "La palabra de Jehová" it is aligned with two Hebrew words, when we try to split those two Hebrew words to realign them one of those two Hebrew words disappears and we are not able to align it.

PhotoNomad0 commented 2 months ago

@elsylambert @danielklapp This should be fixed in v2.4.0 build e1d5248

elsylambert commented 2 months ago

@PhotoNomad0 Not seeing loss of Hebrew word when splitting from a group of words, but after making changes, click on Accept and saving it on the card, seeing this error:

Screenshot 2024-05-16 at 8.49.33 AM.png

Private Zenhub Video

PhotoNomad0 commented 2 months ago

I cannot open this picture. Sent from my iPhoneOn May 16, 2024, at 8:51 AM, elsylambert @.***> wrote: @PhotoNomad0 Not seeing loss of Hebrew word when splitting from a group of words, but after making changes, click on Accept and saving it on the card, seeing this error:

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

PhotoNomad0 commented 2 months ago

@elsylambert I can't open your private Zenhub image and videos - tried following your steps, but am not seeing a problem. Using QA server, tit 1:1 en_ust unfoldingWord.

Also tried the Jon 1:1. es literal and not seeing a problem.

elsylambert commented 2 months ago

Private Zenhub Video

elsylambert commented 2 months ago

@PhotoNomad0 Please check now if the screenshots and video is visible for you?^^

PhotoNomad0 commented 2 months ago

@PhotoNomad0 Please check now if the screenshots and video is visible for you?^^

@elsylambert OK, I now have permission to see the video, but still not seeing the error when I reproduce the steps. I tried several times. Do you still see the problem? It looks like your content needs updating - could that be related to the problem you see?

Screenshot 2024-05-20 at 8 10 53 AM
danielklapp commented 2 months ago

@PhotoNomad0, @elsylambert when I reproduce the steps here's my findings v2.4.0 build 5c6dfd8 QA Don't see the loss of original words when splitting from a group of words, but getting a 409 (Conflict) error after clicking on Accept and saving it to the card. A weird thing happens when trying to merge my work. I can check the Mergeable Resources but can't leave a comment in the description box. Looking at the console it's giving a RangeError: Maximum call stack size exceeded.

Screenshot 2024-05-20 at 12 10 55 PM

Here's my console history if it helps

deploy-preview-648--gateway-edit.netlify.app-1716221161445.log

elsylambert commented 2 months ago

Retested in v2.4.0 build 4b01301 QA this morning with a fresh branch and not seeing Network error. @PhotoNomad0

elsylambert commented 2 months ago

@danielklapp Can you retest with a fresh user branch? if the issue still exist, please write a new separate issue for that.

danielklapp commented 2 months ago

@elsylambert Retested with a fresh branch and issue still persist, will write up a separate issue for it.

PhotoNomad0 commented 2 months ago

@PhotoNomad0, @elsylambert when I reproduce the steps here's my findings v2.4.0 build 5c6dfd8 QA Don't see the loss of original words when splitting from a group of words, but getting a 409 (Conflict) error after clicking on Accept and saving it to the card. A weird thing happens when trying to merge my work. I can check the Mergeable Resources but can't leave a comment in the description box. Looking at the console it's giving a RangeError: Maximum call stack size exceeded. Screenshot 2024-05-20 at 12 10 55 PM Here's my console history if it helps

deploy-preview-648--gateway-edit.netlify.app-1716221161445.log

@danielklapp Yes, it looks like there is an endless recursive loop going on there causing a memory crash. @kintsoogi

danielklapp commented 2 months ago

Tested with v2.4.0 build 542041b QA, looks good to me. The issue I wrote up separate is issue #650.