User is unable to merge their work

[danielklapp]

v2.4.0 build 4b01301 QA When you’re in es-419_gl org and es-419 as the lang. Go to Jon 1:1 in Texto Puente Literal, make a change to any card and save. After saving go to merge my work, your able to check your work under Mergeable Resources but unable to comment in the description box. Looking at the console it's giving a RangeError: Maximum call stack size exceeded.

Here's my console history if it helps deploy-preview-648--gateway-edit.netlify.app-1716221161445.log

[PhotoNomad0]

@danielklapp The log file is missing ^^^

[danielklapp]

@PhotoNomad0 Think I copied and pasted the link over instead of attaching it. Fix it, you can try it again.

[PhotoNomad0]

@kintsoogi This looks like a regression in the latest develop branch. I don't see this problem in the latest v2.3.0 release.

[PhotoNomad0]

@kintsoogi If I revert the tHelps rcl to the version in the last release this problem goes away. It looks like there is a recursion problem that is resulting in a stack overflow.

[PhotoNomad0]

@kintsoogi I discovered a problem with the latest @mui library and MergeDialog. I tried lots of options to get it to work, but for now I am just reverting GWE to use the previous translation-helps-rcl v3.5.16.

[PhotoNomad0]

@danielklapp Can you verify that this is working correctly in develop build? v2.4.0 build bef6853

[danielklapp]

@PhotoNomad0 Tested with v2.4.0 build bef6853 QA, seems to be working correctly. I was able to write a comment in the description field and submit my merge. After submitting the last log in the console was Uncaught (in promise) Error. Is that an error to worry about?

[PhotoNomad0]

@kintsoogi What was happening is that there was an endless loop in the mui library trying to capture focus of the TextArea component. I found a work-around for the symptom of the endless focus loop, but could not fix the problem of not being able to enter text. The TextArea component is implemented as below - it is two textarea's - one for the entered text, and the other is an overlay for description. It looks as if mui is trying to switch focus over to the textarea for entering text when the textarea, is clicked on, but it cannot take control and switch the focus.

[PhotoNomad0]

@PhotoNomad0 Tested with v2.4.0 build bef6853 QA, seems to be working correctly. I was able to write a comment in the description field and submit my merge. After submitting the last log in the console was Uncaught (in promise) Error. Is that an error to worry about?

What was the error?

[danielklapp]

@PhotoNomad0 I retested this morning with v2.4.0 build bef6853 QA and didn’t see the error this time after submitting my merge.

Here's a screenshot and console history of the error I saw from last week.

develop--gateway-edit.netlify.app-1716491637717.log

[PhotoNomad0]

@abelpz - I found the commit for your branch. It looks like in the verse 8 edit there is both an edit with an added word, and the alignment is changed (a second instance of de added). Maybe that is a clue as to what is happening. I'll try to reproduce.

[elsylambert]

This issue still exists @PhotoNomad0

[PhotoNomad0]

This issue still exists @PhotoNomad0

@elsylambert - I am not seeing it in develop v2.4.0 build adfde3f

[elsylambert]

Not seeing the problem in the latest develop v2.4.0 build adfde3f. Able to merge work done in tN branch.

[danielklapp]

Able to write my description and merge my work. Tested with v2.4.0 build adfde3f QA