unfoldingWord / gateway-translate

A tool for editing and translating text in USFM markup

MIT License

2 stars 3 forks source link

Closed mandolyte closed 1 year ago

mandolyte commented 1 year ago

Describe what your pull request addresses

[ ] in DCS open org "Pt-br_gl" and repo "ULB_L3_WA" and any book
[ ] Currently it crashes and takes you back to the login page and clears the cache
[ ] This change will successfully open the book

netlify[bot] commented 1 year ago

Name	Link
Latest commit	db0bb257b893eb0c82ffd001e843aa2aea9b7db0
Latest deploy log	https://app.netlify.com/sites/gateway-translate/deploys/6421b87fe70fb500089dda51
Deploy Preview	https://deploy-preview-165--gateway-translate.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

larsgson commented 1 year ago

This is a fix for now, so I have approved it - as I see it to be good enough for the 0.9 release.

for the next release 1.0, however, then we really need to go one step further and solve this issue, i.e. no longer needing to mangle these IDs.
I will look into how to improve this right away in the upcoming html-usfm-editor monorepo (i.e. the next upcoming version - as an upgrade from uw-editor)