Show Bible Ref navigation in app bar according to if book is opened - and which book is current active

unfoldingWord / gateway-translate

A tool for editing and translating text in USFM markup

MIT License

2 stars 3 forks source link

Show Bible Ref navigation in app bar according to if book is opened - and which book is current active #196

Closed larsgson closed 1 year ago

larsgson commented 1 year ago

The Bible Ref navigation in the app bar does not make sense to be visible, until there is a book opened. Once there is a book opened, then this navigation needs to be showing the position in the current active window

Note: There is a need to keep a reference to which book is the current active window (probably in the AppContext) and change the Bible Ref navigation in the app bar accordingly

elsylambert commented 1 year ago

@abelpz can you please review this issue

abelpz commented 1 year ago

@elsylambert @larsgson isn't this solved in develop?

elsylambert commented 1 year ago

Currently, In develop, there is no navigation bar in the blue header when the user logs in and then when a book is added, Navigation bar shows that book.

It fulfills the definition of done, Im wondering if this issue lingered in In Review for some other reason. @abelpz

elsylambert commented 1 year ago

Looks good in v1.0.0 build 0168902 QA.