search

unfoldingWord / gateway-translate

A tool for editing and translating text in USFM markup
MIT License
2 stars 3 forks source link

Feature larsg get editor content from dcs #25

Closed larsgson closed 2 years ago

larsgson commented 2 years ago

Proskomma importDocument is now working - meaning documents are automatically loaded when needed

Any Bible book can now be opened in an Editor card (still read only - edits are not yet saved anywhere)

netlify[bot] commented 2 years ago

Deploy Preview for gateway-translation failed.

Name Link
Latest commit 669db706b45a87720e82c41011bc06c7f64780a1
Latest deploy log https://app.netlify.com/sites/gateway-translation/deploys/633f42f3a68413000978bbcf
mandolyte commented 2 years ago

Couple of questions:

  1. I can't really merge this until the yalc reference in pkg json is removed, since no one else has your copy of it. Do you have fixes for it? You'll have to work those thru with the PK team: "epitelete-perf-html": "file:.yalc/epitelete-perf-html",
  2. I did replace the above the latest published on NPM. When I ran, then this: image

Is the issue you were referring to at standup on Tuesday?

I do wonder if there might be a timing issue here. Is it possible that the component is rendered before the data.usfmText is ready? Maybe try changing the code to render a circular progress indicator if it doesn't exist yet?

All for now @larsgson

larsgson commented 2 years ago

@mandolyte Hmm, this is strange... I now pushed a new commit where I have reverted to the npm Epitelete version and commented out the extra parameter for readHtml - and it works fine for me locally If you still have problems here, then I will still be online on Monday for a while and maybe we will have to look at this together, to see if we find some difference between our setup