search

unfoldingWord / gateway-translate

A tool for editing and translating text in USFM markup
MIT License
2 stars 3 forks source link

Errors on the console when adding book card through URL #69

Closed elsylambert closed 1 year ago

elsylambert commented 1 year ago
  1. Added Book Gen-Literal. Looks fine.
  2. Added Book Gen-Simplified. Looks fine.
  3. Added Book Gen using this URL: https://qa.door43.org/unfoldingWord/en_ult/src/branch/master/01-GEN.usfm The card shows loading at first and then shows blank with errors in the console. Screenshot 2022-11-08 at 9.08.42 AM.png
elsylambert commented 1 year ago

@mandolyte The URL above ^^ was not the raw file. When I added the raw USFM, https://qa.door43.org/unfoldingWord/en_ult/raw/branch/master/01-GEN.usfm it works. Can there be an indication to the user that the URL is not correct or in the right format?

superdav42 commented 1 year ago

@mandolyte The URL above ^^ was not the raw file. When I added the raw USFM, https://qa.door43.org/unfoldingWord/en_ult/raw/branch/master/01-GEN.usfm it works. Can there be an indication to the user that the URL is not correct or in the right format?

This was fixed in https://github.com/unfoldingWord/gateway-translate/pull/68

elsylambert commented 1 year ago

Looks good in v0.0.14 build 7323d6c QA. Now able to add USFM without opening the raw file, both format works. Invalid URLs open a blank card with a error message indicating to the user that they have entered a invalid USFM.