unfoldingWord / scripture-resources-rcl

A React Component Library for Rendering Scripture Resources.
https://scripture-resources-rcl.netlify.com/
MIT License
0 stars 8 forks source link

Replace HOCs with custom Hooks #7

Closed klappy closed 4 years ago

klappy commented 4 years ago

There are a series of Higher Order Components that follow the old paradigm of React. We need to replace those with the newer Custom Hooks paradigm.

Gitea React Toolkit has a model to pattern using useRepository and RepositoryContext.

Replace existing

Update examples that leverage the older HOC's

birchamp commented 4 years ago

DoD: Higher order components are replaced with custom Hooks and context API. All HOCs are replaced.

klappy commented 4 years ago

This issue is testable on both RCL and App

Overall functionality should be identical but more performant when scrolling through a TSV.

elsylambert commented 4 years ago

0.9.0-rc.6: Small books like Titus opens fairly faster, but books like Mathew and Acts are taking nearly 5-7 secs to load the scripture pane when scrolling down the page. It takes 4-5 seconds for scripture pane to load when move from one page to another. Scripture pane loading performance.mp4.zip

elsylambert commented 4 years ago

Performance on larger books will be enhanced by rcl-#23.

BincyJ commented 4 years ago

@birchamp closed this issue as it's done.