unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Re-Architect loading tools into tC core #3927

Open da1nerd opened 6 years ago

da1nerd commented 6 years ago

Dependencies of tools created for tC core such as wordAlignment or translationWords are not being installed. The current tools only work by accident because tC core happens to use the same dependencies. We need to redesign how tools are loaded into the core so that tools don't crash if using other libraries.

There are two approaches which could be taken in steps for simplicity.

  1. add a script in package.json to install the tool dependencies. This would be fairly easy.
  2. Move the tools out of the core and load them from an external location on the file system.

The final step would provide additional benefits:

  1. Easy for developers to create and add new tools.
  2. Tools could be piped through webpack to entirely remove the concern for dependencies.
  3. Tools could be updated apart from the core.
benjore commented 6 years ago