unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Accepting a WordMAP suggestion as the final alignment does not automatically trigger the "alignment complete toggle" #4940

Closed benjore closed 5 years ago

benjore commented 6 years ago

Story Explanation

User Story

As an aligner, I want the accepting of a WordMAP suggestion as the final needed alignment to automatically trigger the "alignment complete" toggle so that I don't have to do the added step of toggling it even though all the target and original language words have been used.

To reproduce the bug

Screen Shot 2018-08-24 at 3.21.13 PM.png

Screen Shot 2018-08-24 at 3.21.36 PM.png

da1nerd commented 6 years ago

@benjore The completion toggle works as expected for me. However, I'm also using code that has not been merged in yet. I'd suggest re-testing this after #4957 and #4946 are accepted.

benjore commented 6 years ago

@cckozie Can you retest this now that the two issues mentioned above have been closed.

cckozie commented 6 years ago

1.0.0 (8adaf14) Senario A: After manually aligning all non-suggested words, and then accepting (either via the Accept button or clicking on the suggested word(s), the Alignment complete switch is correct set to on. Scenario B: It does not work in this scenario.

  1. Accept the suggested word(s)
  2. Moves one or more of the accepted suggestions back to the word bank
  3. Click the Refresh button
  4. Accept the suggestions Note that the Alignment complete switch remains in the off position
cckozie commented 6 years ago

Not working in 1.0.2 (6ab77c0) Imported this project file Partially aligned verse one as shown here: image

Navigated to verse 1:2. God showed as suggestion. Manually aligned other words as shown here: image

Clicked on the Accept button. Alignment complete did not switch on. image

Moved 'God' back to word bank, clicked refresh, then clicked on the 'God' suggestion. Switch did not toggle on.

cckozie commented 5 years ago

Works in 1.0.2 (f005f02) .