unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Cannot open up expanded scripture pane if en ult is missing #5029

Closed PhotoNomad0 closed 4 years ago

PhotoNomad0 commented 6 years ago

Observed:

Opening up expanded scripture pane if en ult is missing.

To reproduce:

delete the ult bible in the resource/en folder. Then open an acts project. Open wa tool. then on the scripture pane click on the expand button. The UI will show an error.

Problem details:

It looks like tc-ui-toolkit is hardcoded to use en_ult. Found this line in tool: var verseNumbers = Object.keys(biblesWithHighlightedWords['en']['ult'].bibleData[chapter]);

Specs

PhotoNomad0 commented 6 years ago

Screen capture of crash:

crash

elsylambert commented 5 years ago

Retested in 2.0.0 (4b3ebee). Issue still exists. Not seeing the any crashing errors but expand button in scripture pane does not work. Click on Expand button does nothing.

cckozie commented 4 years ago

This has been fixed in 2.2.0 (2375ae5)