unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

Import fail does not report cause #5393

Open bspidel opened 5 years ago

bspidel commented 5 years ago

Prerequisites

Description

Reports fail to download but detects missing verseEdits during migration Examples of non-book projects in #2524 See also #5691

Steps to Reproduce

  1. Online Import https://git.door43.org/tCore-test-data/abu_tit_text_reg
  2. See error in screenshot below.

Screenshots importabu

Console log after import C:\Program Files (x86)\translationCore\resources\app.asar\src\js\helpers\ProjectMigration\migrateToVersion7.js:116 Migration error: Error: ENOENT: no such file or directory, scandir 'C:\Users\Owner\translationCore\imports\abu_tit_text_reg.apps\translationCore\checkData\verseEdits\tit' C:\Program Files (x86)\translationCore\resources\app.asar\src\js\helpers\FileConversionHelpers\index.js:89 TypeError: Cannot convert undefined or null to object at Function.keys () at Object.parseMergeConflictVersion (C:/Program Files (x86)/translationCore/resources/app.asar/src/js/helpers/ProjectValidation/MergeConflictHelpers.js:54:34) at C:/Program Files (x86)/translationCore/resources/app.asar/src/js/actions/MergeConflictActions.js:96:69 at C:\Program Files (x86)\translationCore\resources\app.asar\node_modules\redux-thunk\lib\index.js:11:18 at dispatch (C:\Program Files (x86)\translationCore\resources\app.asar\node_modules\redux\lib\applyMiddleware.js:45:18) at C:/Program Files (x86)/translationCore/resources/app.asar/src/js/actions/MergeConflictActions.js:55:11 at C:\Program Files (x86)\translationCore\resources\app.asar\node_modules\redux-thunk\lib\index.js:11:18 at dispatch (C:\Program Files (x86)\translationCore\resources\app.asar\node_modules\redux\lib\applyMiddleware.js:45:18) at C:/Program Files (x86)/translationCore/resources/app.asar/src/js/actions/ProjectImportStepperActions.js:33:5 at C:\Program Files (x86)\translationCore\resources\app.asar\node_modules\redux-thunk\lib\index.js:11:18 getSafeErrorMessage @ C:\Program Files (x86)\translationCore\resources\app.asar\src\js\helpers\FileConversionHelpers\index.js:89 C:\Program Files (x86)\translationCore\resources\app.asar\src\js\actions\Import\OnlineImportWorkflowActions.js:177 Uncaught (in promise) Object

Expected behavior: (From Koz) The application should give the user some idea of why the import did not work. In many cases, this is because the URL does not point to a project. There already is an alert warning the user of that, and it should be implemented here when that is the problem. "Could not download the project" implies that the problem is in downloading, not in the URL not pointing to a project. Use this alert if the URL does not point to an actual tC or tS project image

Actual behavior: [What actually happens]

Context

Enviorment Tech Version
tc 1.0.2 (1681fcf)
build #
OS

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

RoyalSix commented 5 years ago

https://github.com/unfoldingWord-dev/translationCore/commits/develop/src/js/actions/Import/OnlineImportWorkflowActions.js Need to look through history and find when it stopped being accounted for