unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

WordMAP should not treat the translation identifier as being case sensitive #6534

Closed cckozie closed 4 years ago

cckozie commented 4 years ago

2.1.0 (d45bc64) 6534.zip

  1. Start with an empty projects folder
  2. Drop the two projects from the zip file above into an empty projects folder
  3. Start tC
  4. Import this USFM file 38-ZEC.usfm.zip as English with translation ID of 'ust'
  5. Load the Zec project in wA Note that there are no suggestions for any of the verses, either based on exact match or lemma Here is one example where there should be a suggestion: Alignments in Judges jdg

No suggestion in Zechariah

zec4
cckozie commented 4 years ago

The real problem here is that the wordMAP is treating the translation identifier as being case sensitive in determining language and translation identifier matches. When tC is validating the uniqueness of language/book/translation id, it treats the tid as not being case sensitive. tC always displays the tid in lower case on the projects page. For consistency, I believe it would be better to always treat it as non-case sensitive.

PhotoNomad0 commented 4 years ago

@cckozie - here is a test build to try with Alignment memory using lower case translation ids:

From the release-vx2.1.0-test.2 branch: Linux build 2.1.0 (fcfdbfb) is ready for download. macOS build 2.1.0 (fcfdbfb) is ready for download. Windows x64 build 2.1.0 (fcfdbfb) is ready for download. Windows x32 build 2.1.0 (fcfdbfb) is ready for download.

cckozie commented 4 years ago

@PhotoNomad0 Looks good in the test build

PhotoNomad0 commented 4 years ago

Verified in translationCore 2.1.0 (8b531e4)

cckozie commented 4 years ago

Works correctly in 2.1.0 (8b531e4)