unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

The latest base resources are no longer in the latest build #6659

Closed cckozie closed 4 years ago

cckozie commented 4 years ago

6943 provided for the latest base resources to be in all builds. That feature has been broken in 2.1.0 (228ed0f)

PhotoNomad0 commented 4 years ago

I was able to reproduce this in the latest tCore build 2.1.0 (9be0e63). Investigating...

PhotoNomad0 commented 4 years ago

It looks like the language and resource update scripts are not even being run on the develop builds. for example https://github.com/unfoldingWord/translationCore/runs/416927577

Screen Shot 2020-01-30 at 10 10 23 AM

PhotoNomad0 commented 4 years ago

It looks like it is due to a recent change in build system since older develop builds had this. For example: https://github.com/unfoldingWord/translationCore/runs/382578484?check_suite_focus=true

da1nerd commented 4 years ago

Oops I forgot I disabled those so testing would be faster. UPDATE_RESOURCES needs to be set to true. I'll update that now.

PhotoNomad0 commented 4 years ago

@neutrinog - yes I just saw that in main.yml. Do you set that in .env or is it a github setting?

da1nerd commented 4 years ago

well... at the time I was thinking it would be something configurable at the repo level, but it's not. So I just edited the file and opened a PR. https://github.com/unfoldingWord/translationCore/pull/6662

PhotoNomad0 commented 4 years ago

@neutrinog - I see it is working now. Merged your PR.

da1nerd commented 4 years ago

glad you caught that before I went to bed for reals!

PhotoNomad0 commented 4 years ago

Thank @cckozie for catching it.

PhotoNomad0 commented 4 years ago

Working in translationCore 2.1.0 (c42350b)

Builds here: https://github.com/unfoldingWord/translationCore/actions/runs/33041887

cckozie commented 4 years ago

Latest base resources (el-x-koine, en, hbo, hi) are in both 2.1.0 (e61795c) from github actions and 2.1.0 (aed42f3) from concourse.

elsylambert commented 4 years ago

Base resources are available with the latest build 2.1.0(aed42f3)