search

unfoldingWord / translationCore

Repository for the desktop application translationCore
https://www.translationcore.com
Other
36 stars 11 forks source link

The wA % complete of a project is potentially incorrect when importing an USFM file with alignments #6799

Open cckozie opened 4 years ago

cckozie commented 4 years ago

2.2.0 (2375ae5) en_ult_act_book 2.zip This project shows 99% complete on the wA tool card.

This is the file of the exported project including alignments, and it shows 79% complete on the wA tool card. 45-ACT.usfm.zip

The wA % complete of a project changes after exporting it to usfm with alignments and then importing the exported file

cckozie commented 4 years ago

@birchamp - As in #6742, this one also worked correctly in 2.1.2

birchamp commented 1 year ago

When a verse is marked complete, do the unaligned words get any sort of attribute to show that is complete? @PhotoNomad0

PhotoNomad0 commented 1 year ago

@birchamp, @elsylambert - We keep alignment complete toggle data by verse. When alignment complete toggle is on, the verse is 100% complete even if there are unaligned words. On USFM export only alignments and bible text are included in the file. None of the extra data is included (e.g. alignment complete, notes, verse edit history, bookmarks, etc.). Then on USFM import, no verses are assumed complete, but are checked again. If there are unaligned words in the verse, that verse is counted as 0% complete. In the project given above there were a lot of verses that had the alignment complete toggled, but still had unaligned words, so the score is much less after re-import.